From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbbAKLgT (ORCPT ); Sun, 11 Jan 2015 06:36:19 -0500 Received: from mail-la0-f43.google.com ([209.85.215.43]:37499 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbbAKLgN (ORCPT ); Sun, 11 Jan 2015 06:36:13 -0500 Date: Sun, 11 Jan 2015 12:36:18 +0100 From: Johan Hovold To: Jeremiah Mahler Cc: Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [RESEND PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk Message-ID: <20150111113618.GA23221@localhost> References: <1419066698-2684-1-git-send-email-jmmahler@gmail.com> <1420937073-20835-2-git-send-email-jmmahler@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1420937073-20835-2-git-send-email-jmmahler@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 10, 2015 at 04:44:32PM -0800, Jeremiah Mahler wrote: > If a USB serial device is unplugged while there is an active program > using the device it will spam the logs with -EPROTO (71) messages as it > attempts to retry. Can you change this to "might spam", as which error message, and if it is at all printed, depends on host controller and what (hub) devices are used. > Most serial usb drivers (metro-usb, pl2303, mos7840, ...) only output > these messages for debugging. The generic driver treats these as > errors. > > Change the default output for the generic serial driver from error to > debug. Please also correct the commit summary (Subject) so that it matches what this revised patch now does (you silence all non-critical error messages). Fix this up and I'll take both patches. Thanks, Johan