From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbbATOUG (ORCPT ); Tue, 20 Jan 2015 09:20:06 -0500 Received: from mail-ie0-f175.google.com ([209.85.223.175]:41438 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbbATOUE (ORCPT ); Tue, 20 Jan 2015 09:20:04 -0500 Date: Tue, 20 Jan 2015 14:19:54 +0000 From: Lee Jones To: Bjorn Andersson Cc: Rob Herring , Mark Brown , Josh Cartwright , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v8 3/3] regulator: qcom-rpm: Add missing state flag in call to RPM Message-ID: <20150120141954.GS13701@x1> References: <1417038661-30209-1-git-send-email-bjorn.andersson@sonymobile.com> <1417038661-30209-4-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1417038661-30209-4-git-send-email-bjorn.andersson@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark, Do you want a pull-request for this, or can I absorb it right into my tree? > This adds the missing state parameter to the call down to the RPM. This > is currently hard coded to the active state, as that's all we're > supporting at this moment. > > Signed-off-by: Bjorn Andersson > --- > drivers/regulator/qcom_rpm-regulator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c > index b55cd5b..8f66040 100644 > --- a/drivers/regulator/qcom_rpm-regulator.c > +++ b/drivers/regulator/qcom_rpm-regulator.c > @@ -198,6 +198,7 @@ static int rpm_reg_write(struct qcom_rpm_reg *vreg, > vreg->val[req->word] |= value << req->shift; > > return qcom_rpm_write(vreg->rpm, > + QCOM_RPM_ACTIVE_STATE, > vreg->resource, > vreg->val, > vreg->parts->request_len); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog