linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Omar Sandoval <osandov@osandov.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@lst.de>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create
Date: Wed, 28 Jan 2015 18:09:52 +0100	[thread overview]
Message-ID: <20150128170952.GB17528@lst.de> (raw)
In-Reply-To: <0d8672e771b8fc1fef94db4b40b418afc8763c2b.1422338890.git.osandov@osandov.com>

On Mon, Jan 26, 2015 at 10:16:53PM -0800, Omar Sandoval wrote:
> get_acl gets a reference which we must release in the error cases.
> 
> Signed-off-by: Omar Sandoval <osandov@osandov.com>

Looks good, but at this point goto-based unwinding might be in order.

  reply	other threads:[~2015-01-28 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  6:16 [PATCH] posix_acl: fix reference leaks in posix_acl_create Omar Sandoval
2015-01-28 17:09 ` Christoph Hellwig [this message]
2015-02-02  7:55   ` Omar Sandoval
2015-02-02 14:19     ` Christoph Hellwig
2015-02-09  5:45       ` [PATCH v2] " Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128170952.GB17528@lst.de \
    --to=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@osandov.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).