From: Johan Hovold <johan@kernel.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH v3 1/5] usb: serial: add register map for F81232
Date: Thu, 29 Jan 2015 11:04:24 +0100 [thread overview]
Message-ID: <20150129100424.GB5312@localhost> (raw)
In-Reply-To: <54C99CEE.8070802@gmail.com>
On Thu, Jan 29, 2015 at 10:37:34AM +0800, Peter Hung wrote:
> Hello.
>
> 1. For retry Issue:
>
> These patches is referenced from our other usb serial product. That
> product maybe not ack the control ep command when It's in very heavily
> loading. Our workaround is to modify driver to retry more times if it
> timeout because it's f/w can't upgrade with usb protocol. I will remove
> the retry mechanic and test for it again.
That sounds good.
> 2. For some function/variable not used:
>
> The original driver is lacking a lot of feature. My first patch strategy
> is putting all needed function / variables in patch 1 and apply it in
> following patches. Sorry for my wrong strategy, I'll change it with more
> meaningful and logical patchset and resend it.
Perhaps you just need to break the patches up further.
Also if you get checkpatch warnings for code you haven't touched, you
can either ignore them or fix it separately in preparatory patch.
Just try to group related changes together.
> Thanks for your patient and advice.
No worries.
In the future when posting to the lists, please try to respond inline
(as I am above) rather than top-post, and remove context that isn't
relevant (e.g. code that isn't relevant) for the discussion at hand.
Thanks,
Johan
prev parent reply other threads:[~2015-01-29 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 5:57 [PATCH v3 1/5] usb: serial: add register map for F81232 Peter Hung
2015-01-28 17:55 ` Johan Hovold
2015-01-29 2:37 ` Peter Hung
2015-01-29 10:04 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129100424.GB5312@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).