From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754933AbbA2QLi (ORCPT ); Thu, 29 Jan 2015 11:11:38 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:37403 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbbA2QLh (ORCPT ); Thu, 29 Jan 2015 11:11:37 -0500 Date: Thu, 29 Jan 2015 10:11:24 -0600 From: Felipe Balbi To: Heikki Krogerus CC: Felipe Balbi , Greg Kroah-Hartman , Baolu Lu , , , Kishon Vijay Abraham I Subject: Re: [PATCH 7/8] phy: helpers for USB ULPI PHY registering Message-ID: <20150129161124.GE21217@saruman.tx.rr.com> Reply-To: References: <1422025978-178336-1-git-send-email-heikki.krogerus@linux.intel.com> <1422025978-178336-8-git-send-email-heikki.krogerus@linux.intel.com> <20150129050355.GB9098@saruman.tx.rr.com> <20150129143441.GD2570@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ytoMbUMiTKPMT3hY" Content-Disposition: inline In-Reply-To: <20150129143441.GD2570@kuha.fi.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ytoMbUMiTKPMT3hY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2015 at 04:34:41PM +0200, Heikki Krogerus wrote: > On Wed, Jan 28, 2015 at 11:03:55PM -0600, Felipe Balbi wrote: > > On Fri, Jan 23, 2015 at 05:12:57PM +0200, Heikki Krogerus wrote: > > > ULPI PHYs need to be bound to their controllers with a > > > lookup. This adds helpers that the ULPI drivers can use to > > > do both, the registration of the PHY and the lookup, at the > > > same time. > > >=20 > > > Signed-off-by: Heikki Krogerus > > > Cc: Kishon Vijay Abraham I > > > --- > > > drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ > > > 1 file changed, 31 insertions(+) > > > create mode 100644 drivers/phy/ulpi_phy.h > > >=20 > > > diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h > > > new file mode 100644 > > > index 0000000..ac49fb6 > > > --- /dev/null > > > +++ b/drivers/phy/ulpi_phy.h > > > @@ -0,0 +1,31 @@ > > > +#include > > > + > > > +/** > > > + * Helper that registers PHY for a ULPI device and adds a lookup for= binding it > > > + * and it's controller, which is always the parent. > > > + */ > > > +static inline struct phy > > > +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) > > > +{ > > > + struct phy *phy; > > > + int ret; > > > + > > > + phy =3D phy_create(&ulpi->dev, NULL, ops); > > > + if (IS_ERR(phy)) > > > + return phy; > > > + > > > + ret =3D phy_create_lookup(phy, "usb2-phy", dev_name(ulpi->dev.paren= t)); > >=20 > > I wonder if this would break DT-based boot where PHY phandle is > > available. Kishon ? >=20 > If there are of_node for the PHY, we will not use this binding at all. where is that taken care of ? ulpi_phy_create() is called unconditionally. --=20 balbi --ytoMbUMiTKPMT3hY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUylurAAoJEIaOsuA1yqRE5LEP+gNPmefo6b1ptgua8BaWHLkO RCIHAYHDpZYQAh+wuKheFhol5Sffo2fJfzP6SpVuPxe7s67cOHnkeRjdl9CgNGF7 5URXUWjm6rWJQCElfspTuYUVYpStmMoDjxWSVLXpjKjTsFuAddP43lLE3mfEqezD cSPTZ1xfUJ3/5Qb9E/ieNg6Hv7qZS6stlTBgkjGI7uJTbnRX6RphhHhSaqIq+ZVT EMLrCszrbaciAfxgKH/5LrDfyD7nPNiYB/GzFTdy+L4uxkAMrpTuzg5av0BsZkMW Gul9qpJnh/0PKZlseQ7EYN1PKFiTdacWTsS0zk9ExTUev4vsHyDda+fuoRFVMkd4 t17m+rnJwx/cNYBT4f8wJqv+SON7QIah8XJHKu4Ewe0MyCbugiu9xERqIRIn+N07 79va9dUS7ER9pUc4s4RKFTfaRjciUcpfBTYoAUmeiLp6+xxgELqbJuCMVdyCymVH xY2WD1ePK7dudKteREH5Wlgt6b662P1xgFOUt6Vm4p8EkGllG/zZKSp+tKDJm1Mt 9pEK050uA6pOvsLs59jxgBNEuky4gVHRUR5KvDPFJMNpfabRdSGRyicBgvEiQoAc wz6YKj31XuAFkYub0QBoHsiqguSxRwNiYp1XVh60B+M0Zmm6J/k+pwQ9W8GE4+Tx 4E/uUevpvbi57M0RvYa6 =rDvH -----END PGP SIGNATURE----- --ytoMbUMiTKPMT3hY--