From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757376AbbA2SrG (ORCPT ); Thu, 29 Jan 2015 13:47:06 -0500 Received: from mga02.intel.com ([134.134.136.20]:36068 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757301AbbA2SrC (ORCPT ); Thu, 29 Jan 2015 13:47:02 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="447140327" Date: Thu, 29 Jan 2015 10:47:19 -0800 From: David Cohen To: Felipe Balbi Cc: Heikki Krogerus , Greg Kroah-Hartman , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , david.e.box@linux.intel.com Subject: Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY Message-ID: <20150129184719.GD2784@psi-dev26.jf.intel.com> References: <1422025978-178336-1-git-send-email-heikki.krogerus@linux.intel.com> <1422025978-178336-9-git-send-email-heikki.krogerus@linux.intel.com> <20150129050951.GC9098@saruman.tx.rr.com> <20150129143053.GC2570@kuha.fi.intel.com> <20150129162049.GG21217@saruman.tx.rr.com> <20150129180416.GB2784@psi-dev26.jf.intel.com> <20150129182538.GC2784@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150129182538.GC2784@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 29, 2015 at 10:25:38AM -0800, David Cohen wrote: > On Thu, Jan 29, 2015 at 10:04:16AM -0800, David Cohen wrote: > > On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote: > > > On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote: > > > > > Also, I was chatting in private with David and, apparently, there's a > > > > > way to request for eye diagram data from BIOS straight. That's more > > > > > in-line with what we would do for DT-based boots, passing that > > > > > eye-diagram data as a DT attribute. > > > > > > > > > > Care to comment ? If that's the case, I'd rather use that BIOS hook and > > > > > remove ulpi_read() from probe(). > > > > > > > > I'm not familiar with such method. But if there is one, I'm not > > > > against it. I need to check it. > > > > > > David ? Care to comment ? > > > > I agree with Heikki's proposal to use BIOS hook and remove ulpi_read() > > from probe(). That address one of my chicken/egg concerns. > > Oops. I misinterpreted the thread. Heikki didn't propose that :) > Let me get things mature and reply to here. I talked to David Box (CC'ed him to this reply). We can add an integer value to ACPI and request it during phy's probe using ACPI's Device Specific Data (_DSD). That would end the need to have phy functional during probe (being compatible to BYT-CR and to module support) and would be more compatible to DT as well. Br, David > > Br, David > > > > > Br, David > > > > > > > > -- > > > balbi > > > >