From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759398AbbA3I3v (ORCPT ); Fri, 30 Jan 2015 03:29:51 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:43425 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbbA3I3u (ORCPT ); Fri, 30 Jan 2015 03:29:50 -0500 Date: Fri, 30 Jan 2015 11:28:47 +0300 From: Dan Carpenter To: Thomas Gleixner , Yingjoe Chen Cc: Jason Cooper , Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [patch] irqchip: mtk-sysirq: fix an error code Message-ID: <20150130082847.GB21357@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "chip_data->intpol_base" used to be an ERR_PTR() but we recently changed it to be NULL. We need to update the error code as well because "PTR_ERR(NULL)" means success where really we want to return -ENOMEM. Fixes: cdb647a772e9 ('irqchip: mtk-sysirq: Get irq number from register resource size') Signed-off-by: Dan Carpenter diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index eaf0a71..22eb34c 100644 --- a/drivers/irqchip/irq-mtk-sysirq.c +++ b/drivers/irqchip/irq-mtk-sysirq.c @@ -144,7 +144,7 @@ static int __init mtk_sysirq_of_init(struct device_node *node, chip_data->intpol_base = ioremap(res.start, size); if (!chip_data->intpol_base) { pr_err("mtk_sysirq: unable to map sysirq register\n"); - ret = PTR_ERR(chip_data->intpol_base); + ret = -ENOMEM; goto out_free; }