LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	namhyung@kernel.org, Ingo Molnar <mingo@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH perf/core 1/2] [BUGFIX] perf-probe: Fix to handle optimized not-inlined but has no instance
Date: Fri, 30 Jan 2015 11:32:20 -0300
Message-ID: <20150130143220.GB3101@kernel.org> (raw)
In-Reply-To: <20150130142135.GA3101@kernel.org>

Em Fri, Jan 30, 2015 at 11:21:35AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 30, 2015 at 06:37:44PM +0900, Masami Hiramatsu escreveu:
> > Fix to handle optimized no-inline functions which have
> > only function definition but no actual instance at
> > that point. To fix this problem, we need to find actual
> > instance of the function.
> > 
> > Without this patch:
> >   ----
> >   # perf probe -a __up
> >   Failed to get entry address of __up.
> >     Error: Failed to add events.
> >   # perf probe -L __up
> >   Specified source line is not found.
> >     Error: Failed to show lines.
> >   ----
> > 
> > With this patch:
> >   ----
> >   # perf probe -a __up
> >   Added new event:
> >     probe:__up           (on __up)
> > 
> >   You can now use it in all perf tools, such as:
> > 
> >           perf record -e probe:__up -aR sleep 1
> > 
> >   # perf probe -L __up
> >   <__up@/home/fedora/ksrc/linux-3/kernel/locking/semaphore.c:0>
> >         0  static noinline void __sched __up(struct semaphore *sem)
> >            {
> >                   struct semaphore_waiter *waiter = list_first_entry(&sem->wait_
> >                                                           struct semaphore_waite
> >         4         list_del(&waiter->list);
> >         5         waiter->up = true;
> >         6         wake_up_process(waiter->task);
> >         7  }
> >   ----
> 
> Since __up here was built in some other way, I looked for another

Nah, I saw you trying to add "perf probe -a __up" and stopped there,
hadn't seen that it fails _as well_ for just listing the source code...

Yes, I managed to reproduce the problem and test your fix, it works:

  [root@zoo ~]# perf probe --del __up
  Removed event: probe:__up
  [root@zoo ~]# perf probe -L __up
  Specified source line is not found.
    Error: Failed to show lines.

---->>>>>> APPLY THE PATCH, rebuild and try again:

  [root@zoo ~]# 
  [root@zoo ~]# perf probe -L __up
  <__up@/home/git/linux/kernel/locking/semaphore.c:0>
        0  static noinline void __sched __up(struct semaphore *sem)
           {
                  struct semaphore_waiter *waiter = list_first_entry(&sem->wait_list,
                                                          struct semaphore_waiter, list);
        4         list_del(&waiter->list);
        5         waiter->up = true;
        6         wake_up_process(waiter->task);
        7  }
  [root@zoo ~]#

--------------------------------------------------------------

So its just this other case that fails, vmalloc_fault, can you check
this one? Does it happen in your machine as well?

Applying your patch, thanks,

- Arnaldo

> 'noinline' function to try, and it failed here:
> 
>   [root@zoo ~]# perf probe -L vmalloc_fault | head -5
>   <vmalloc_fault@/home/git/linux/arch/x86/mm/fault.c:0>
>         0  static noinline int vmalloc_fault(unsigned long address)
>         1  {
>            	pgd_t *pgd, *pgd_ref;
>            	pud_t *pud, *pud_ref;
>   [root@zoo ~]# perf probe vmalloc_fault
>   Added new event:
>   Failed to write event: Invalid argument
>     Error: Failed to add events.
> 
> ---->>>>>> APPLY THE PATCH, rebuild and try again:
> 
>   [root@zoo ~]# perf probe vmalloc_fault
>   Added new event:
>   Failed to write event: Invalid argument
>     Error: Failed to add events.
>   [root@zoo ~]# perf probe -v vmalloc_fault
>   probe-definition(0): vmalloc_fault 
>   symbol:vmalloc_fault file:(null) line:0 offset:0 return:0 lazy:(null)
>   0 arguments
>   Looking at the vmlinux_path (7 entries long)
>   Using /lib/modules/3.19.0-rc6+/build/vmlinux for symbols
>   Open Debuginfo file: /lib/modules/3.19.0-rc6+/build/vmlinux
>   Try to find probe point from debuginfo.
>   Probe point found: vmalloc_fault+0
>   Found 1 probe_trace_events.
>   Opening /sys/kernel/debug/tracing/kprobe_events write=1
>   Added new event:
>   Writing event: p:probe/vmalloc_fault _text+289600
>   Failed to write event: Invalid argument
>     Error: Failed to add events. Reason: Invalid argument (Code: -22)
>   [root@zoo ~]# grep -w vmalloc_fault /proc/kallsyms
>   ffffffff81046b40 t vmalloc_fault
>   [root@zoo ~]# grep -w _text /proc/kallsyms 
>   ffffffff81000000 T _text
>   [root@zoo ~]# python 
>   Python 2.7.5 (default, Nov  3 2014, 14:26:24) 
>   [GCC 4.8.3 20140911 (Red Hat 4.8.3-7)] on linux2
>   Type "help", "copyright", "credits" or "license" for more information.
>   >>> 0xffffffff81046b40 - 0xffffffff81000000
>   289600L
>   >>> 
>   [root@zoo ~]# readelf -s /lib/modules/3.19.0-rc6+/build/vmlinux | egrep -w _text\|vmalloc_fault
>     3499: ffffffff81046b40   410 FUNC    LOCAL  DEFAULT    1 vmalloc_fault
>    48873: ffffffff81000000     0 NOTYPE  GLOBAL DEFAULT    1 _text
>   [root@zoo ~]# 
> 
> ---------------------------------------------------------------------------
> 
> So perhaps I need a 'noinline' _and_ '__sched', so that I have a "optimized
> no-inline functions which have only function definition but no actual instance
> at that point"?
> 
> Looking for one, will post here after objdump -dS finishes...
> 
> - Arnaldo

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  9:37 [PATCH perf/core 0/2] perf-probe: bugfix and update Masami Hiramatsu
2015-01-30  9:37 ` [PATCH perf/core 1/2] [BUGFIX] perf-probe: Fix to handle optimized not-inlined but has no instance Masami Hiramatsu
2015-01-30 14:21   ` Arnaldo Carvalho de Melo
2015-01-30 14:32     ` Arnaldo Carvalho de Melo [this message]
2015-02-02  8:41       ` Masami Hiramatsu
2015-02-08  8:37     ` Masami Hiramatsu
2015-02-11 20:42       ` Arnaldo Carvalho de Melo
2015-02-19 14:31         ` [PATCH perf/core ] perf-probe: Check kprobes blacklist when adding new events Masami Hiramatsu
2015-02-25 21:50           ` Arnaldo Carvalho de Melo
2015-02-28  9:30           ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2015-02-18 18:25   ` [tip:perf/core] perf probe: Fix to handle optimized not-inlined functions tip-bot for Masami Hiramatsu
2015-01-30  9:37 ` [PATCH perf/core 2/2] [DOC] perf-probe: Update perf-probe document Masami Hiramatsu
2015-02-18 18:25   ` [tip:perf/core] perf probe: Update man page tip-bot for Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130143220.GB3101@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git