From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762665AbbA3QDk (ORCPT ); Fri, 30 Jan 2015 11:03:40 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:42890 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbbA3QDh (ORCPT ); Fri, 30 Jan 2015 11:03:37 -0500 Date: Fri, 30 Jan 2015 10:03:39 -0600 From: Felipe Balbi To: Heikki Krogerus CC: Felipe Balbi , Greg Kroah-Hartman , Baolu Lu , , , Kishon Vijay Abraham I Subject: Re: [PATCH 7/8] phy: helpers for USB ULPI PHY registering Message-ID: <20150130160339.GC15318@saruman.tx.rr.com> Reply-To: References: <1422025978-178336-1-git-send-email-heikki.krogerus@linux.intel.com> <1422025978-178336-8-git-send-email-heikki.krogerus@linux.intel.com> <20150129050355.GB9098@saruman.tx.rr.com> <20150129143441.GD2570@kuha.fi.intel.com> <20150129161124.GE21217@saruman.tx.rr.com> <20150130103301.GG2570@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG" Content-Disposition: inline In-Reply-To: <20150130103301.GG2570@kuha.fi.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XMCwj5IQnwKtuyBG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 30, 2015 at 12:33:01PM +0200, Heikki Krogerus wrote: > On Thu, Jan 29, 2015 at 10:11:24AM -0600, Felipe Balbi wrote: > > On Thu, Jan 29, 2015 at 04:34:41PM +0200, Heikki Krogerus wrote: > > > On Wed, Jan 28, 2015 at 11:03:55PM -0600, Felipe Balbi wrote: > > > > On Fri, Jan 23, 2015 at 05:12:57PM +0200, Heikki Krogerus wrote: > > > > > ULPI PHYs need to be bound to their controllers with a > > > > > lookup. This adds helpers that the ULPI drivers can use to > > > > > do both, the registration of the PHY and the lookup, at the > > > > > same time. > > > > >=20 > > > > > Signed-off-by: Heikki Krogerus > > > > > Cc: Kishon Vijay Abraham I > > > > > --- > > > > > drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ > > > > > 1 file changed, 31 insertions(+) > > > > > create mode 100644 drivers/phy/ulpi_phy.h > > > > >=20 > > > > > diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h > > > > > new file mode 100644 > > > > > index 0000000..ac49fb6 > > > > > --- /dev/null > > > > > +++ b/drivers/phy/ulpi_phy.h > > > > > @@ -0,0 +1,31 @@ > > > > > +#include > > > > > + > > > > > +/** > > > > > + * Helper that registers PHY for a ULPI device and adds a lookup= for binding it > > > > > + * and it's controller, which is always the parent. > > > > > + */ > > > > > +static inline struct phy > > > > > +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) > > > > > +{ > > > > > + struct phy *phy; > > > > > + int ret; > > > > > + > > > > > + phy =3D phy_create(&ulpi->dev, NULL, ops); > > > > > + if (IS_ERR(phy)) > > > > > + return phy; > > > > > + > > > > > + ret =3D phy_create_lookup(phy, "usb2-phy", dev_name(ulpi->dev.p= arent)); > > > >=20 > > > > I wonder if this would break DT-based boot where PHY phandle is > > > > available. Kishon ? > > >=20 > > > If there are of_node for the PHY, we will not use this binding at all. > >=20 > > where is that taken care of ? ulpi_phy_create() is called > > unconditionally. >=20 > When you call phy_get(). tks --=20 balbi --XMCwj5IQnwKtuyBG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUy6tbAAoJEIaOsuA1yqREAZcQAKdVdsuBvHpEzStM7gZHfqBT GgNWRylYZWj2XlkfQNy0ZcluJxn5wgN593sQmiI06fFN2id7qvsD9hA0hMlXfdGk 3XPp1rvucAzXVtLlwDjIhVzOjn7BhqKEymw2ofCa8Ch7G+Hj09x9zsLmtXgIVamw LLKjXegmqex70vxQCLAh3EVCtwExn5piW6xlRamSbopuzdre3FsvMXRD1wIl0ZJs H4OgDKsB/tYfezIhn9MqW9E9MpVkg0cv0o3cxnmVmUQuQNhuWzAd9r/rpNsvxY2k 1jT+MtZCIieVCVwuS6X0dsCCCFgheLDQ6JhXE8ZiH92XEHonXs/XYipdmiQa97Eg yDhpcHX6qTBsrM/UvM1sydjhqF1JEq49cDgeii4tpEYE+3jsNEynitXWRFJTq9n2 gsjC3CncWeo3sFBrEUE0InorzWkR4dwUOUN+1/ezQNzWRj3fIeMD6aIZTXI0+ojL k8HeityF/ZVC7/ZNTaCMN81fSktW2nJIGpa7L2nSGKw/WsA9ExE1dGzVd1D983xz RayKejc56bDnNpmgju+f4tHeOSVk7F/KnONZRJfLAqjnhvza4MFHiD5xzP89EgwY Vx59/7xIDXz0AgiL9jDf2PuKhwplG4xH+eOUnzbYiGfyb9ADUl+ASq7oImFrKZSA K/Mw3fzQRwIZqftWAkCS =OEpb -----END PGP SIGNATURE----- --XMCwj5IQnwKtuyBG--