From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216AbbBABcU (ORCPT ); Sat, 31 Jan 2015 20:32:20 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:32815 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbbBABcS (ORCPT ); Sat, 31 Jan 2015 20:32:18 -0500 Date: Sat, 31 Jan 2015 17:32:17 -0800 (PST) Message-Id: <20150131.173217.1599465880594497324.davem@davemloft.net> To: haiyangz@microsoft.com Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH net] hyperv: Fix the error processing in netvsc_send() From: David Miller In-Reply-To: <1422563689-31036-1-git-send-email-haiyangz@microsoft.com> References: <1422563689-31036-1-git-send-email-haiyangz@microsoft.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sat, 31 Jan 2015 17:32:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Thu, 29 Jan 2015 12:34:49 -0800 > The existing code frees the skb in EAGAIN case, in which the skb will be > retried from upper layer and used again. > Also, the existing code doesn't free send buffer slot in error case, because > there is no completion message for unsent packets. > This patch fixes these problems. > > (Please also include this patch for stable trees. Thanks!) > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied and queued up for -stable, thanks.