From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755944AbbAaSjK (ORCPT ); Sat, 31 Jan 2015 13:39:10 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:45580 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbbAaSjH (ORCPT ); Sat, 31 Jan 2015 13:39:07 -0500 Date: Sat, 31 Jan 2015 13:38:53 -0500 From: Neil Horman To: SF Markus Elfring Cc: "David S. Miller" , Vlad Yasevich , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] net: sctp: Deletion of an unnecessary check before the function call "kfree" Message-ID: <20150131183853.GB24821@localhost.localdomain> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54CD0DCF.9020804@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CD0DCF.9020804@users.sourceforge.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 31, 2015 at 06:15:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 18:10:03 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > net/sctp/associola.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index f791edd..3c2aefc 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -391,8 +391,7 @@ void sctp_association_free(struct sctp_association *asoc) > sctp_asconf_queue_teardown(asoc); > > /* Free pending address space being deleted */ > - if (asoc->asconf_addr_del_pending != NULL) > - kfree(asoc->asconf_addr_del_pending); > + kfree(asoc->asconf_addr_del_pending); > > /* AUTH - Free the endpoint shared keys */ > sctp_auth_destroy_keys(&asoc->endpoint_shared_keys); > -- > 2.2.2 > > Sure, seems reasonable Acked-By: Neil Horman