From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030AbbBAUaK (ORCPT ); Sun, 1 Feb 2015 15:30:10 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:34196 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbbBAUaI (ORCPT ); Sun, 1 Feb 2015 15:30:08 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Sun, 1 Feb 2015 21:30:01 +0100 From: Stefan Richter To: Joe Perches Cc: linux-kernel@vger.kernel.org Subject: Re: checkpatch: length of git commit IDs Message-ID: <20150201213001.06ae0fd7@kant> In-Reply-To: <1422821345.12856.1.camel@perches.com> References: <20150201205916.0f321555@kant> <1422821345.12856.1.camel@perches.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.25; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 01 Joe Perches wrote: > On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote: > > I was just told that 12 is less than 12: > > > > > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit > > > 01234567890ab ("commit description")' #5: > > > Commit 2a48fc0ab242 "block: autoconvert trivial BKL users to private > > Yeah, that message isn't very descriptive. > > It really wants parentheses around the commit > message like: > > Commit 2a48fc0ab242 ("block: autoconvert trivial BKL users to private > > Try the version in -next. I think it has a > better message description. Thanks for the tip; this works for me. (checkpatch.pl from current -next does actually not complain about the line without parentheses.) -- Stefan Richter -=====-===== --=- ----= http://arcgraph.de/sr/