From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983AbbBCDaR (ORCPT ); Mon, 2 Feb 2015 22:30:17 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:50259 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbbBCDaO (ORCPT ); Mon, 2 Feb 2015 22:30:14 -0500 Date: Mon, 02 Feb 2015 19:30:12 -0800 (PST) Message-Id: <20150202.193012.1930991920361082218.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: nhorman@tuxdriver.com, vyasevich@gmail.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] net: sctp: Deletion of an unnecessary check before the function call "kfree" From: David Miller In-Reply-To: <54CD0DCF.9020804@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <54CD0DCF.9020804@users.sourceforge.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Feb 2015 19:30:13 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Sat, 31 Jan 2015 18:15:59 +0100 > From: Markus Elfring > Date: Sat, 31 Jan 2015 18:10:03 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied to net-next, thanks.