From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183AbbBBMLn (ORCPT ); Mon, 2 Feb 2015 07:11:43 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44948 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754230AbbBBMLm (ORCPT ); Mon, 2 Feb 2015 07:11:42 -0500 Date: Mon, 2 Feb 2015 12:11:37 +0000 From: Mark Brown To: Nicholas Mc Guire Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150202121137.GO21293@sirena.org.uk> References: <1422865837-10357-1-git-send-email-hofrat@osadl.org> <1422865837-10357-2-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vET4Xl8WLaXB2XUg" Content-Disposition: inline In-Reply-To: <1422865837-10357-2-git-send-email-hofrat@osadl.org> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vET4Xl8WLaXB2XUg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 02, 2015 at 03:30:33AM -0500, Nicholas Mc Guire wrote: > - ret = wait_for_completion_timeout(&spi->c, > - msecs_to_jiffies(SSP_TIMEOUT)); > - if (!ret) { > + if (!wait_for_completion_timeout(&spi->c, > + msecs_to_jiffies(SSP_TIMEOUT))) { Your new indentation is pretty confusing here, I had to look twice to realize that the msecs_to_jiffies() is still an argument to wait_for_completion(). Generally arguments to functions should be aligned with the opening ( for the function, or at least much more deeply aligned than the function itself (as was the case with the original code). --vET4Xl8WLaXB2XUg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJUz2l4AAoJECTWi3JdVIfQp24H/3o9SLtcwpAJi3YKizec2TXp 6h+JKrGD2WAZXAyf8B9Hn3xYjz830C5V4+NEbRwPdR1zRcpOBUNHdIiyjjiZikWx lOdcLV+YH0vn1xkAicc+tAG2Ow2yx9dwqysJoJZj3KEggfNBi+lo7uMOLAFZgFZ0 AuX2MIfJZTIAKMBLZ+SaSnEDTr2I0dnENZtXRtBkV4okGpKPcP70mm0nfxFRIMeq DF4WhPobxzG2dvxTgywS5FSnZJz5L6XdAmSD0elekRBDYoU3yguPxSV/WFPvgWkz MSREuzQPP51dIPWRDNKyOWViONHRbGbmh6HhiM71oXVHBMytozP5qed6zrv/YuY= =fzuo -----END PGP SIGNATURE----- --vET4Xl8WLaXB2XUg--