From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932394AbbBBMQI (ORCPT ); Mon, 2 Feb 2015 07:16:08 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44952 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753870AbbBBMQF (ORCPT ); Mon, 2 Feb 2015 07:16:05 -0500 Date: Mon, 2 Feb 2015 12:16:01 +0000 From: Mark Brown To: Nicholas Mc Guire Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150202121601.GP21293@sirena.org.uk> References: <1422865837-10357-1-git-send-email-hofrat@osadl.org> <1422865837-10357-5-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mQZYU1XZRcIUQ9HK" Content-Disposition: inline In-Reply-To: <1422865837-10357-5-git-send-email-hofrat@osadl.org> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/5] spi: ti-qspi: cleanup wait_for_completion return handling X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mQZYU1XZRcIUQ9HK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 02, 2015 at 03:30:36AM -0500, Nicholas Mc Guire wrote: > - ret = wait_for_completion_timeout(&qspi->transfer_complete, > - QSPI_COMPLETION_TIMEOUT); > - if (ret == 0) { > + if (!wait_for_completion_timeout(&qspi->transfer_complete, > + QSPI_COMPLETION_TIMEOUT)) { Same indentation issue as with the earlier patch here. I also just noticed that you're not CCing driver maintainers, please try to do that so they get a chance to review things. --mQZYU1XZRcIUQ9HK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJUz2qAAAoJECTWi3JdVIfQoloH/0CCLtprOWLQwM1AzJuEn4by Cak1k+Y60sYyWsP9vVTN8KXTZa8AipC5dcAXLi6SFj5E/qcBsllL56628NyoETgw nURPVoXPFGIiq0uRvP/ke1rfAurOI3FFAQ/7pyuaiFHnTKWsQNpXSFQf7znDA68q IHuipc+lWimN+E0Ta8CM0NL/xoAZ25X35wDfttxyGSmj9/JrEiVPFU9CkUck+urn TG0/MjQWWDVe++gF2nuMZrE2JnLse16IjkBJuTLOKobZRHO+nAUkOjxXH7Dz03a1 53l4Dqs94EpOLXuC/J4UJAMQwws8fvfn8sotA9kMH0U0Azfid8PP3wszM4isHX0= =3ZpS -----END PGP SIGNATURE----- --mQZYU1XZRcIUQ9HK--