From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Jaeger <cj@linux.com>
Cc: linux-kernel@vger.kernel.org,
Yalin Wang <yalin.wang@sonymobile.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH linux-next] lib: Kconfig: use bool instead of boolean
Date: Mon, 2 Feb 2015 14:27:32 -0800 [thread overview]
Message-ID: <20150202142732.9ea4d2f604ef79cbe180f5fe@linux-foundation.org> (raw)
In-Reply-To: <1422889156-19830-1-git-send-email-cj@linux.com>
On Mon, 2 Feb 2015 09:59:16 -0500 Christoph Jaeger <cj@linux.com> wrote:
> Keyword 'boolean' for type definition attributes is considered
> deprecated and, therefore, should not be used anymore.
>
> See http://lkml.kernel.org/r/cover.1418003065.git.cj@linux.com
> See http://lkml.kernel.org/r/1419108071-11607-1-git-send-email-cj@linux.com
>
> ...
>
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -14,7 +14,7 @@ config BITREVERSE
> tristate
>
> config HAVE_ARCH_BITREVERSE
> - boolean
> + bool
> default n
> depends on BITREVERSE
> help
Your patch patches 556d2f055bf6d ("ARM: 8187/1: add
CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction") which appears
in linux-next via the ARM tree.
There are many uses of "boolean" in lib/Kconfig. Converting just one
of them is inefficient and odd.
556d2f055bf6d is a bit of a surprise. It looks good to me from a
non-ARM perspective - the __builtin_constant_p() optimisation is
sensible, although bitrev on a constant probably isn't very common.
I'm not sure about the ARM part though! __bitrev8() is pretty damn
fast. Presumably an inlined rbit instruction is faster still, but not
very much?
The Kconfig help text in 556d2f055bf6d rather needs some caring for.
next prev parent reply other threads:[~2015-02-02 22:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 14:59 [PATCH linux-next] lib: Kconfig: use bool instead of boolean Christoph Jaeger
2015-02-02 22:27 ` Andrew Morton [this message]
2015-02-02 22:37 ` Paul Bolle
2015-02-02 22:46 ` Andrew Morton
2015-02-02 22:52 ` Paul Bolle
2015-02-02 22:53 ` Randy Dunlap
2015-02-02 22:59 ` Stephen Rothwell
2015-02-02 23:05 ` Russell King - ARM Linux
2015-02-02 23:18 ` Andrew Morton
2015-02-02 23:30 ` Russell King - ARM Linux
2015-02-02 23:40 ` Andrew Morton
2015-02-02 23:12 ` Christoph Jaeger
2015-02-02 23:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202142732.9ea4d2f604ef79cbe180f5fe@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cj@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=yalin.wang@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).