From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965346AbbBBWuo (ORCPT ); Mon, 2 Feb 2015 17:50:44 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:32940 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755100AbbBBWul convert rfc822-to-8bit (ORCPT ); Mon, 2 Feb 2015 17:50:41 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Stephen Boyd , "Julia Lawall" From: Mike Turquette In-Reply-To: <54CFFBCF.90706@codeaurora.org> Cc: "Tomeu Vizoso" , linux-kernel@vger.kernel.org, "Paul Walmsley" , "Tony Lindgren" , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, t-kristo@ti.com, cocci@systeme.lip6.fr References: <1422011024-32283-1-git-send-email-tomeu.vizoso@collabora.com> <1422011024-32283-4-git-send-email-tomeu.vizoso@collabora.com> <20150201212432.22722.70917@quantum> <54CFE1FE.7040404@codeaurora.org> <54CFFBCF.90706@codeaurora.org> Message-ID: <20150202225036.421.43421@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances Date: Mon, 02 Feb 2015 14:50:36 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2015-02-02 14:35:59) > On 02/02/15 13:31, Julia Lawall wrote: > > > > On Mon, 2 Feb 2015, Stephen Boyd wrote: > > > >> Julia, > >> > >> Is there a way we can write a coccinelle script to check for this? The > >> goal being to find all drivers that are comparing struct clk pointers or > >> attempting to dereference them. There are probably other frameworks that > >> could use the same type of check (regulator, gpiod, reset, pwm, etc.). > >> Probably anything that has a get/put API. > > Comparing or dereferencing pointers of a particular type should be > > straightforward to check for. Is there an example of how to use the > > parent_index value to fix the problem? > > > > I'm not sure how to fix this case with parent_index values generically. > I imagine it would be highly specific to the surrounding code to the > point where we couldn't fix it automatically. For example, if it's a clk > consumer (not provider like in this case) using an index wouldn't be the > right fix. We would need some sort of clk API that we don't currently > have and I would wonder why clock consumers even care to compare such > pointers in the first place. Ack. Is there precedent for a "Don't do that" kind of response? Regards, Mike > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project >