From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965080AbbBDAK7 (ORCPT ); Tue, 3 Feb 2015 19:10:59 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:58083 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932998AbbBDAK5 (ORCPT ); Tue, 3 Feb 2015 19:10:57 -0500 Date: Tue, 03 Feb 2015 16:10:54 -0800 (PST) Message-Id: <20150203.161054.379086029122558267.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: jhs@mojatatu.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection From: David Miller In-Reply-To: <54CD042E.6030606@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <54CD042E.6030606@users.sourceforge.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Feb 2015 16:10:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Sat, 31 Jan 2015 17:34:54 +0100 > From: Markus Elfring > Date: Sat, 31 Jan 2015 17:18:48 +0100 > > The meta_delete() function could be called in four cases by the > em_meta_change() function during error handling even if the passed > variable "meta" contained still a null pointer. > > * This implementation detail could be improved by adjustments for jump labels. > > * Let us return immediately after the first failed function call according to > the current Linux coding style convention. > > * Let us delete also unnecessary checks for the variables "err" and > "meta" there. > > Signed-off-by: Markus Elfring I kind of like the way the code is now, branching to the end of the function even when cleanups are not necessary. Inter-function return statements make code harder to audit, for locking errors, resource leaks, etc.