From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966167AbbBCQyB (ORCPT ); Tue, 3 Feb 2015 11:54:01 -0500 Received: from smtprelay0159.hostedemail.com ([216.40.44.159]:49011 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965894AbbBCQx5 (ORCPT ); Tue, 3 Feb 2015 11:53:57 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2892:2896:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:4250:4321:5007:6261:6742:7875:8603:9040:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12291:12296:12438:12517:12519:12555:12683:12740:13019:13069:13311:13357:13972:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: fork79_3ee82b3536b2f X-Filterd-Recvd-Size: 3447 Date: Tue, 3 Feb 2015 11:53:51 -0500 From: Steven Rostedt To: Gilad Broner Cc: James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, ygardi@codeaurora.org, draviv@codeaurora.org, Lee Susman , Sujit Reddy Thumma , Vinayak Holikatti , "James E.J. Bottomley" , Ingo Molnar , Oleg Nesterov , Petr Mladek , Mathieu Desnoyers , Vaibhav Nagarnaik Subject: Re: [PATCH v1 3/4] scsi: ufs: add trace events and dump prints for debug Message-ID: <20150203115351.58994f7d@gandalf.local.home> In-Reply-To: <1422977841-25036-4-git-send-email-gbroner@codeaurora.org> References: <1422977841-25036-1-git-send-email-gbroner@codeaurora.org> <1422977841-25036-4-git-send-email-gbroner@codeaurora.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Feb 2015 17:37:19 +0200 Gilad Broner wrote: > Add trace events to driver to allow monitoring and profilig > of activities such as PM suspend/resume, hibernate enter/exit, > clock gating and clock scaling up/down. > In addition, add UFS host controller register dumps to provide > detailed information in case of errors to assist in analysis > of issues. > > Signed-off-by: Dolev Raviv > Signed-off-by: Subhash Jadavani > Signed-off-by: Lee Susman > Signed-off-by: Sujit Reddy Thumma > Signed-off-by: Yaniv Gardi > --- > drivers/scsi/ufs/ufs-qcom.c | 53 +++++ > drivers/scsi/ufs/ufshcd.c | 509 ++++++++++++++++++++++++++++++++++++++++--- > drivers/scsi/ufs/ufshcd.h | 49 ++++- > drivers/scsi/ufs/ufshci.h | 1 + > include/linux/ftrace_event.h | 3 + > include/trace/events/ufs.h | 227 +++++++++++++++++++ > +static inline void ufshcd_cond_add_cmd_trace(struct ufs_hba *hba, > + unsigned int tag, const char *str) > +{ > + if (FTRACE_EVENT_ENABLED(ufshcd_command)) What's this? Not mentioned at all in the change log. > + ufshcd_add_command_trace(hba, tag, str); > +} > +#else > diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h > index 0bebb5c..54a4a63 100644 > --- a/include/linux/ftrace_event.h > +++ b/include/linux/ftrace_event.h > @@ -606,4 +606,7 @@ perf_trace_buf_submit(void *raw_data, int size, int rctx, u64 addr, > } > #endif > > +#define FTRACE_EVENT_ENABLED(name) \ > + ((event_##name).flags & (1 << (TRACE_EVENT_FL_WAS_ENABLED_BIT)))\ > + > #endif /* _LINUX_FTRACE_EVENT_H */ NACK! Please use trace__enabled(), for instance, trace_ufshcd_command_enabled(). This also uses jump_labels and is a nop when it is not enabled. -- Steve