Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

From: Mark Brown <broonie@kernel.org>
To: Manuel Lauss <manuel.lauss@gmail.com>
Cc: Bo Shen <voice.shen@atmel.com>,
	Manuel Lauss <manuel.lauss@googlemail.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Richard Purdie <richard@openedhand.com>,
	patches@opensource.wolfsonmicro.com, linux-sound@vger.kernel.org,
	alsa-devel <alsa-devel@alsa-project.org>,
	linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself
Date: Tue, 3 Feb 2015 12:44:41 +0000	[thread overview]
Message-ID: <20150203124441.GK21293@sirena.org.uk> (raw)
In-Reply-To: <CAOLZvyE6W8-X2_M+-KQNry2VPwLzwbBLuxr5Z5EdBQo7Skv2RQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote:

> +    wm8731->mclk = devm_clk_get(&spi->dev, "mclk");
> +    if (IS_ERR(wm8731->mclk)) {
> +        wm8731->mclk = NULL;
> +        dev_warn(&spi->dev, "assuming static MCLK\n");
> +    }

This is broken for both deferred probe and in the case where the clock
API genuinely returns a NULL clock.  Other than that it's the kind of
thing that we've done for some other drivers, though it's not good to
have to do this.  Check them for correct behaviour.

The coding style is also not right for the whole patch and there's a
lot of missing error checking.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]