From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755995AbbBCOQj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Feb 2015 09:16:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58862 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754017AbbBCOQi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Feb 2015 09:16:38 -0500
Date: Tue, 3 Feb 2015 15:16:25 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs
Message-ID: <20150203141625.GA1359@krava.brq.redhat.com>
References: <20150202193501.962297539@goodmis.org>
 <20150202193553.340946602@goodmis.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150202193553.340946602@goodmis.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote:

SNIP

>  }
> @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint)
>  void perf_debugfs_set_path(const char *mntpt)
>  {
>  	snprintf(debugfs_mountpoint, strlen(debugfs_mountpoint), "%s", mntpt);
> -	set_tracing_events_path(mntpt);
> +	set_tracing_events_path("tracing/", mntpt);
> +}
> +
> +static const char *find_tracefs(void)
> +{
> +	const char *path = __perf_tracefs_mount(NULL);
> +
> +	return path;

I guess you ommited the fprint(stderr... ) warning on purpose
(like in find_debugfs), because the tracefs is not upstream yet, right?

maybe we want at least pr_debug warning here..
anyway, other than that the patchset looks ok to me:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

>  }
>  
>  static const char *find_debugfs(void)
>  {
> -	const char *path = perf_debugfs_mount(NULL);
> +	const char *path = __perf_debugfs_mount(NULL);
>  
>  	if (!path)
>  		fprintf(stderr, "Your kernel does not support the debugfs filesystem");
> @@ -344,6 +377,7 @@ static const char *find_debugfs(void)
>   */

SNIP