From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966096AbbBCREO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Feb 2015 12:04:14 -0500
Received: from mail-we0-f180.google.com ([74.125.82.180]:43804 "EHLO
	mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965602AbbBCREM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Feb 2015 12:04:12 -0500
Date: Tue, 3 Feb 2015 17:04:06 +0000
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Benjamin LaHaise <bcrl@kvack.org>, linux-aio@kvack.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] iommu/amd: Fix amd_iommu_free_device()
Message-ID: <20150203170406.29d3e31c@jbarnes-t420>
In-Reply-To: <20150203122551.GJ24151@twins.programming.kicks-ass.net>
References: <20150201144058.GM2974@kvack.org>
	<CA+55aFx+HVnythC+BpmDMa0Oeq1MxnXXOvs771DXpJ=PBjy1Nw@mail.gmail.com>
	<20150201221458.GN2974@kvack.org>
	<CA+55aFzAPms_orX7TY6zGCg=G-yXCrr5z7LMme7xcrXCAk6JAQ@mail.gmail.com>
	<20150202001628.GO2974@kvack.org>
	<CA+55aFy2URGTL_XKQhEO_4dTc3KNJDm9Z0O_1Gqs4G3TvW7APg@mail.gmail.com>
	<20150203112733.GM26304@twins.programming.kicks-ass.net>
	<20150203122551.GJ24151@twins.programming.kicks-ass.net>
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 3 Feb 2015 13:25:51 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Feb 03, 2015 at 12:27:33PM +0100, Peter Zijlstra wrote:
> > drivers/iommu/amd_iommu_v2.c-static void
> > put_device_state_wait(struct device_state *dev_state)
> > drivers/iommu/amd_iommu_v2.c-{ drivers/iommu/amd_iommu_v2.c-
> > DEFINE_WAIT(wait); drivers/iommu/amd_iommu_v2.c-
> > drivers/iommu/amd_iommu_v2.c-   prepare_to_wait(&dev_state->wq,
> > &wait, TASK_UNINTERRUPTIBLE); drivers/iommu/amd_iommu_v2.c-   if
> > (!atomic_dec_and_test(&dev_state->count))
> > drivers/iommu/amd_iommu_v2.c:           schedule();
> > drivers/iommu/amd_iommu_v2.c-   finish_wait(&dev_state->wq, &wait);
> > drivers/iommu/amd_iommu_v2.c- drivers/iommu/amd_iommu_v2.c-
> > free_device_state(dev_state); drivers/iommu/amd_iommu_v2.c-}
> > 
> > No loop...
> 
> Jesse, any objections to this?

None from me, seems reasonable.  But this is Joerg's code I think, so
he should ack.

Jesse