From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965991AbbBEEaA (ORCPT ); Wed, 4 Feb 2015 23:30:00 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41019 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259AbbBEE37 (ORCPT ); Wed, 4 Feb 2015 23:29:59 -0500 Date: Wed, 04 Feb 2015 20:29:58 -0800 (PST) Message-Id: <20150204.202958.1260717828060513191.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put" From: David Miller In-Reply-To: <54D118BA.3080001@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <54D118BA.3080001@users.sourceforge.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Feb 2015 20:29:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Tue, 03 Feb 2015 19:51:38 +0100 > From: Markus Elfring > Date: Tue, 3 Feb 2015 19:47:33 +0100 > > The of_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.