From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932734AbbBDLXL (ORCPT ); Wed, 4 Feb 2015 06:23:11 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:56387 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbbBDLXJ (ORCPT ); Wed, 4 Feb 2015 06:23:09 -0500 Date: Wed, 4 Feb 2015 12:23:11 +0100 From: Johan Hovold To: Peter Hung Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH v4 1/7] usb: serial: modify bulk-in/out size for F81232 Message-ID: <20150204112311.GA13757@localhost> References: <1422598421-6236-1-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422598421-6236-1-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 02:13:35PM +0800, Peter Hung wrote: > The F81232 real bulk-in/out ep buffer size is 64Bytes > > Signed-off-by: Peter Hung > --- > drivers/usb/serial/f81232.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c > index c5dc233..4f42e9d 100644 > --- a/drivers/usb/serial/f81232.c > +++ b/drivers/usb/serial/f81232.c > @@ -304,8 +304,8 @@ static struct usb_serial_driver f81232_device = { > }, > .id_table = id_table, > .num_ports = 1, > - .bulk_in_size = 256, > - .bulk_out_size = 256, > + .bulk_in_size = 64, > + .bulk_out_size = 64, These buffer sizes can be larger than the endpoint sizes for increased throughput (the host controller driver will break them up). If you still want them to match the endpoint sizes you should just leave them unset (0) and usb-serial core will set them for you. Johan