From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966783AbbBDPXj (ORCPT ); Wed, 4 Feb 2015 10:23:39 -0500 Received: from 8bytes.org ([81.169.241.247]:60037 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966694AbbBDPXA (ORCPT ); Wed, 4 Feb 2015 10:23:00 -0500 Date: Wed, 4 Feb 2015 16:22:59 +0100 From: Joerg Roedel To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] regulator: Fix build breakage on !REGULATOR Message-ID: <20150204152259.GN3702@8bytes.org> References: <1423046728-31000-1-git-send-email-k.kozlowski@samsung.com> <1423047011.3987.2.camel@AMDC1943> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423047011.3987.2.camel@AMDC1943> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 04, 2015 at 11:50:11AM +0100, Krzysztof Kozlowski wrote: > > #ifdef CONFIG_REGULATOR > > void regulator_has_full_constraints(void); > > +int regulator_suspend_prepare(suspend_state_t state); > > +int regulator_suspend_finish(void); > > #else > > static inline void regulator_has_full_constraints(void) > > { > > } > > +static inline int regulator_suspend_prepare(suspend_state_t state) > > +{ > > + return 0; > > +} > > +static inline int regulator_suspend_finish(void) > > +{ > > + return 0; > > +} > > #endif > > > > #endif My solution would have been: diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 603820e..0f3f860 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -25,6 +25,7 @@ menuconfig ARCH_EXYNOS select S5P_DEV_MFC select SRAM select MFD_SYSCON + select REGULATOR if PM_SLEEP help Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) But that will work too, so: Acked-by: Joerg Roedel