From: Mike Turquette <mturquette@linaro.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>
Cc: "Stephen Boyd" <sboyd@codeaurora.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Ulrich Hecht" <ulrich.hecht+renesas@gmail.com>,
"Wolfram Sang" <wsa@sang-engineering.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()
Date: Wed, 04 Feb 2015 14:01:52 -0800 [thread overview]
Message-ID: <20150204220152.421.38508@quantum> (raw)
In-Reply-To: <54D25AAA.8070904@cogentembedded.com>
Quoting Sergei Shtylyov (2015-02-04 09:45:14)
> Hello.
>
> On 02/04/2015 08:32 PM, Wolfram Sang wrote:
>
> >> Anyone may call clk_round_rate() with a zero rate value, so we have to
> >> protect against that.
>
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> > I agree that this should not be fixed in the core because the fixup is
> > really driver dependant.
>
> Dunno, zero frequency seems generally insane to me.
It is useful to find the lowest frequency a clock can support. Basically
it is a search for the floor frequency.
Regards,
Mike
>
> WBR, Sergei
>
next prev parent reply other threads:[~2015-02-04 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 12:27 [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate() Geert Uytterhoeven
2015-02-04 13:31 ` Sergei Shtylyov
2015-02-04 13:50 ` Laurent Pinchart
2015-02-04 17:32 ` Wolfram Sang
2015-02-04 17:45 ` Sergei Shtylyov
2015-02-04 22:01 ` Mike Turquette [this message]
2015-02-04 22:04 ` Sergei Shtylyov
2015-02-04 22:14 ` Sergei Shtylyov
2015-02-05 17:19 ` Laurent Pinchart
2015-02-05 17:46 ` Mike Turquette
2015-02-06 11:12 ` Sergei Shtylyov
2015-02-04 22:05 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204220152.421.38508@quantum \
--to=mturquette@linaro.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wsa@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).