From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756677AbbBEIhd (ORCPT ); Thu, 5 Feb 2015 03:37:33 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:42271 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbBEIhc (ORCPT ); Thu, 5 Feb 2015 03:37:32 -0500 Date: Thu, 05 Feb 2015 00:37:30 -0800 (PST) Message-Id: <20150205.003730.1411687823089677821.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: hsweeten@visionengravers.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] net: ep93xx_eth: Delete unnecessary checks before the function call "kfree" From: David Miller In-Reply-To: <54D23415.6070005@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <54D23415.6070005@users.sourceforge.net> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Feb 2015 00:37:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Wed, 04 Feb 2015 16:00:37 +0100 > From: Markus Elfring > Date: Wed, 4 Feb 2015 15:56:58 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.