From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbbBEUWI (ORCPT ); Thu, 5 Feb 2015 15:22:08 -0500 Received: from smtprelay0146.hostedemail.com ([216.40.44.146]:56832 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751192AbbBEUWG (ORCPT ); Thu, 5 Feb 2015 15:22:06 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 10,1,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:196:355:379:541:599:800:877:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1622:1711:1730:1747:1777:1792:2194:2199:2393:2525:2553:2561:2564:2682:2685:2693:2859:2895:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6261:6671:6742:7514:7875:7903:8660:9025:9040:9072:9388:10004:10049:10394:10400:10848:10967:11026:11232:11473:11657:11658:11914:12043:12438:12517:12519:12555:12663:12740:13007:13025:13069:13148:13230:13311:13357:13618:14096:14097:14513:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: move32_6922d919ad905 X-Filterd-Recvd-Size: 3491 Date: Thu, 5 Feb 2015 15:22:01 -0500 From: Steven Rostedt To: Sedat Dilek Cc: Paul McKenney , Dave Hansen , "Rafael J. Wysocki" , "Rafael J. Wysocki" , linux-next , LKML , Stephen Rothwell , Kristen Carlson Accardi , "H. Peter Anvin" , Rik van Riel , Mel Gorman Subject: Re: linux-next: Tree for Feb 4 Message-ID: <20150205152201.49d55905@gandalf.local.home> In-Reply-To: References: <20150205005716.GS5370@linux.vnet.ibm.com> <20150205015144.GT5370@linux.vnet.ibm.com> <54D3186F.7030500@sr71.net> <20150205130343.6ac0eda9@gandalf.local.home> <20150205130802.289a8be0@gandalf.local.home> <54D3B253.3050000@sr71.net> <20150205183412.GI5370@linux.vnet.ibm.com> <54D3B7F5.9070209@sr71.net> <20150205184537.GJ5370@linux.vnet.ibm.com> <20150205145816.7c38a7df@gandalf.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Feb 2015 21:07:27 +0100 Sedat Dilek wrote: > > Is this Paul's version of the patch or mine? If it is just mine, do you > > know if Paul's version triggers this too? > > > > This one which entered Pauls rcu-next tree. > > [1] http://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git/commit/?h=rcu/next&id=2b27cf7317d8a99a50bead9faccd54b46b6f0c41 That's mine. It looks like the condition will be tested before it calls and rcu code. Which is why I was confused that it still gave a splat. Paul posted a patch before this that did the check outside the trace point. This one: http://marc.info/?l=linux-kernel&m=142310961217650&w=2 > > >> ( I did not build from scratch but re-invoking make "updated" the > >> files touched by Steven's patch, see attached build-log. ) > >> > >> Unfortunately, the call-trace remains when doing an offlining of cpu1. > >> ( It's good to see it's reproducible. ) > > > > Was the tracepoint enabled? Or was there some other rcu call that > > triggered this. Or would cpu_online(smp_processor_id()) return true at > > this point? > > > > Thanks Steve for jumping into this one! > > Good point. > I looked at my kernel-config (which I already sent :-)). > > Do I need to enable...? > > # CONFIG_RCU_TRACE is not set > > ...or even more? > What I meant by the tracepoint being enabled, was not that it was configured in (I'm assuming it was), but that you started tracing? echo 1 > /sys/kernel/debug/tracing/events/enable or echo 1 > /sys/kernel/debug/tracing/events/tlb/tlb_flushed/enable -- Steve