From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752923AbbBESeW (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Feb 2015 13:34:22 -0500
Received: from e38.co.us.ibm.com ([32.97.110.159]:45082 "EHLO
	e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752678AbbBESeU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Feb 2015 13:34:20 -0500
Date: Thu, 5 Feb 2015 10:34:12 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Dave Hansen <dave@sr71.net>
Cc: Steven Rostedt <rostedt@goodmis.org>, sedat.dilek@gmail.com,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-next <linux-next@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Kristen Carlson Accardi <kristen@linux.intel.com>,
        "H. Peter Anvin" <hpa@linux.intel.com>, Rik van Riel <riel@redhat.com>,
        Mel Gorman <mgorman@suse.de>
Subject: Re: linux-next: Tree for Feb 4
Message-ID: <20150205183412.GI5370@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20150205001019.GA12362@linux.vnet.ibm.com>
 <CA+icZUUPKNR1ua49NLVGv0i_gu9ZkVrReP_dgAWm8RPVY8Nr+w@mail.gmail.com>
 <20150205005716.GS5370@linux.vnet.ibm.com>
 <CA+icZUWvBDC0FHX-OXLpjnSBbZceam_9KRBq4tcOM1jpJk0emQ@mail.gmail.com>
 <20150205015144.GT5370@linux.vnet.ibm.com>
 <CA+icZUUHBh-voBUfYEwajL7upnj3SJC47zJN-WnRW_7tnEnQsA@mail.gmail.com>
 <54D3186F.7030500@sr71.net>
 <20150205130343.6ac0eda9@gandalf.local.home>
 <20150205130802.289a8be0@gandalf.local.home>
 <54D3B253.3050000@sr71.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54D3B253.3050000@sr71.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15020518-0029-0000-0000-000007B52DE6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 05, 2015 at 10:11:31AM -0800, Dave Hansen wrote:
> On 02/05/2015 10:08 AM, Steven Rostedt wrote:
> > --- a/include/trace/events/tlb.h
> > +++ b/include/trace/events/tlb.h
> > @@ -13,11 +13,13 @@
> >  	{ TLB_LOCAL_SHOOTDOWN,		"local shootdown" },		\
> >  	{ TLB_LOCAL_MM_SHOOTDOWN,	"local mm shootdown" }
> >  
> > -TRACE_EVENT(tlb_flush,
> > +TRACE_EVENT_CONDITION(tlb_flush,
> >  
> >  	TP_PROTO(int reason, unsigned long pages),
> >  	TP_ARGS(reason, pages),
> >  
> > +	TP_CONDITION(cpu_online(smp_processor_id())),
> 
> That's a pretty reasonable fix, although it would be nice if the
> debugging was easier to hit.

Looks very good to me!

Unless someone else speaks up, I will carry this patch.

>                               Did I actually need to be
> onlining/offlining CPUs to hit the splat that Sedat was reporting?

Yep, you do need to offline at least one CPU to hit that splat.

							Thanx, Paul