From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754786AbbBFGtE (ORCPT ); Fri, 6 Feb 2015 01:49:04 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:38416 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbbBFGtB (ORCPT ); Fri, 6 Feb 2015 01:49:01 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [1/2] cw1200: Delete an unnecessary check before the function call "release_firmware" From: Kalle Valo In-Reply-To: <54D24D1F.50001@users.sourceforge.net> To: SF Markus Elfring Cc: Solomon Peachy , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Message-Id: <20150206064901.1EFAE140CB9@smtp.codeaurora.org> Date: Fri, 6 Feb 2015 06:49:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Wed, 4 Feb 2015 16:32:15 +0100 > > The release_firmware() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks, 2 patches applied to wireless-drivers-next.git: df970d39b90e cw1200: Delete an unnecessary check before the function call "release_firmware" ee4ddad82356 cw1200: Less function calls in cw1200_load_firmware_cw1200() after error detection Kalle Valo