From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932075AbbBFVMv (ORCPT ); Fri, 6 Feb 2015 16:12:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37148 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755109AbbBFVMu (ORCPT ); Fri, 6 Feb 2015 16:12:50 -0500 Date: Fri, 6 Feb 2015 16:12:34 -0500 From: Mike Snitzer To: SF Markus Elfring Cc: Alasdair Kergon , Neil Brown , dm-devel@redhat.com, linux-raid@vger.kernel.org, Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy" Message-ID: <20150206211234.GA14803@redhat.com> References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54CF93BB.40206@users.sourceforge.net> <54CF9666.5060407@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CF9666.5060407@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 02 2015 at 10:23am -0500, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 2 Feb 2015 15:30:37 +0100 > > The dm_table_destroy() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. Your proposed patch (while technically correct) hurts code clarity. Nack.