From: Mark Brown <broonie@kernel.org>
To: Peter Rosin <peda@lysator.liu.se>
Cc: alsa-devel@alsa-project.org, Peter Rosin <peda@axentia.se>,
Bo Shen <voice.shen@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates
Date: Sat, 7 Feb 2015 07:09:51 +0800 [thread overview]
Message-ID: <20150206230951.GL31311@finisterre.sirena.org.uk> (raw)
In-Reply-To: <1423050745-6372-1-git-send-email-peda@lysator.liu.se>
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
On Wed, Feb 04, 2015 at 12:52:25PM +0100, Peter Rosin wrote:
> One thing remains a bit unclear, and that is the 500ppm deduction. Is
> that really warranted? The number was just pulled out of my hat...
I don't really get what this is supposed to be protecting against.
> + case SND_SOC_DAIFMT_CBM_CFS:
> + case SND_SOC_DAIFMT_CBM_CFM:
> + t.min = 8000;
> + t.max = ssc_p->mck_rate / mck_div / frame_size;
> + /* Take away 500ppm, just to be on the safe side. */
> + t.max -= t.max / 2000;
> + t.openmin = t.openmax = 0;
> + t.integer = 0;
> + ret = snd_interval_refine(i, &t);
As I understand it this is a straight divider rather than something
that's doing dithering or anything else more fancy. Given that it seems
as well just to trust the clock rate we've got - we don't do any error
tracking with the clock API (perhaps we should) and for many
applications some degree of divergence from the nominal rate is not
*too* bad for audio systems (for application specific values of "some"
and "too" of course). If it is just dividers I'm not sure the situation
is really improved materially by knocking off the top frequency.
If we are doing something more fancy than divididing my analysis is off
base of course.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-02-07 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 11:52 [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates Peter Rosin
2015-02-06 23:09 ` Mark Brown [this message]
2015-02-07 10:51 ` Peter Rosin
2015-02-09 3:06 ` Bo Shen
2015-02-09 7:35 ` Peter Rosin
2015-02-09 8:00 ` Bo Shen
2015-02-09 8:17 ` Peter Rosin
2015-02-09 3:09 ` Bo Shen
2015-02-09 8:09 ` Peter Rosin
2015-02-09 8:37 ` Bo Shen
2015-02-09 9:07 ` Peter Rosin
2015-02-09 9:41 ` Bo Shen
2015-02-09 10:25 ` Peter Rosin
2015-02-09 10:37 ` Bo Shen
2015-02-09 14:50 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206230951.GL31311@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peda@lysator.liu.se \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).