From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753736AbbBGKdT (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Feb 2015 05:33:19 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:37684 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752186AbbBGKdR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Feb 2015 05:33:17 -0500
Date: Sat, 7 Feb 2015 13:32:49 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
        "James E. J. Bottomley" <JBottomley@parallels.com>,
        QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in
 qla4xxx_is_session_exists() after error detection
Message-ID: <20150207103249.GA5155@mwanda>
References: <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net>
 <54D53BE4.7010807@users.sourceforge.net>
 <54D53CF1.8050009@users.sourceforge.net>
 <20150207093322.GA5206@mwanda>
 <alpine.DEB.2.02.1502071110330.2241@localhost6.localdomain6>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1502071110330.2241@localhost6.localdomain6>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: acsinet22.oracle.com [141.146.126.238]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 07, 2015 at 11:11:03AM +0100, Julia Lawall wrote:
> On Sat, 7 Feb 2015, Dan Carpenter wrote:
> 
> > On Fri, Feb 06, 2015 at 11:15:13PM +0100, SF Markus Elfring wrote:
> > > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> > > index 2a00fd3..a7ca479 100644
> > > --- a/drivers/scsi/qla4xxx/ql4_os.c
> > > +++ b/drivers/scsi/qla4xxx/ql4_os.c
> > > @@ -6327,17 +6327,15 @@ static int qla4xxx_is_session_exists(struct scsi_qla_host *ha,
> > >  				     uint32_t *index)
> > >  {
> > >  	struct ddb_entry *ddb_entry;
> > > -	struct ql4_tuple_ddb *fw_tddb = NULL;
> > > -	struct ql4_tuple_ddb *tmp_tddb = NULL;
> > >  	int idx;
> > >  	int ret = QLA_ERROR;
> > > +	struct ql4_tuple_ddb *tmp_tddb;
> > > +	struct ql4_tuple_ddb *fw_tddb = vzalloc(sizeof(*fw_tddb));
> > >  
> > 
> > Don't do allocations in the initializers.  Same for patches 3 and 4 as
> > well.
> 
> Why not?  I can think of some reasons, but I am wondering what is the 
> precise one.

1)  People gloss over initializers without reading them.  You shouldn't
    put complicated code in initializers.  Sarah Sharp is more strict on
    this than I am.  http://www.spinics.net/lists/linux-usb/msg44389.html

2)  It means you have to put a line of separation between the allocation
    and the NULL check, but they should be next to each other.

regards,
dan carpenter