From: Sascha Hauer <s.hauer@pengutronix.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Matthias Brugger" <matthias.bgg@gmail.com>,
"James Liao" <jamesjj.liao@mediatek.com>,
"Mike Turquette" <mturquette@linaro.org>,
"YH Chen (陳昱豪)" <yh.chen@mediatek.com>,
linux-kernel@vger.kernel.org,
"Henry Chen" <henryc.chen@mediatek.com>,
"Rob Herring" <robh+dt@kernel.org>,
kernel@pengutronix.de,
"Yingjoe Chen (陳英洲)" <Yingjoe.Chen@mediatek.com>,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Lee Jones" <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/13] ARM: dts: mediatek: Enable clock support for Mediatek MT8135.
Date: Mon, 9 Feb 2015 12:25:00 +0100 [thread overview]
Message-ID: <20150209112500.GU12209@pengutronix.de> (raw)
In-Reply-To: <20150209105134.GF8656@n2100.arm.linux.org.uk>
On Mon, Feb 09, 2015 at 10:51:34AM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 09, 2015 at 11:47:21AM +0100, Sascha Hauer wrote:
> > From: James Liao <jamesjj.liao@mediatek.com>
> >
> > This patch adds MT8135 clock controllers into device tree.
> > @@ -86,6 +87,18 @@
> > clock-frequency = <32000>;
> > #clock-cells = <0>;
> > };
> > +
> > + clk_null: clk_null {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <0>;
> > + };
> > +
> > + clk26m: clk26m {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <26000000>;
> > + };
>
> Is this supposed to be here?
The clock support needs at least the clk26m clk. Do you think it should
be in another patch or not present at all?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-02-09 11:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 10:47 [PATCH v5]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-02-09 10:47 ` [PATCH 01/13] clk: dts: mediatek: add Mediatek MT8135 clock bindings Sascha Hauer
2015-02-09 13:35 ` Philipp Zabel
2015-02-09 10:47 ` [PATCH 02/13] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-02-13 7:41 ` Tomasz Figa
2015-02-13 12:06 ` Sascha Hauer
2015-02-13 13:22 ` Tomasz Figa
2015-02-09 10:47 ` [PATCH 03/13] clk: mediatek: Add reset controller support Sascha Hauer
2015-02-09 13:35 ` Philipp Zabel
2015-02-09 10:47 ` [PATCH 04/13] clk: mediatek: Add basic clocks for Mediatek MT8135 Sascha Hauer
2015-02-09 10:47 ` [PATCH 05/13] clk: dts: mediatek: add Mediatek MT8173 clock bindings Sascha Hauer
2015-02-09 10:47 ` [PATCH 06/13] clk: mediatek: Add basic clocks for Mediatek MT8173 Sascha Hauer
2015-02-13 9:56 ` Tomasz Figa
2015-02-19 8:24 ` Sascha Hauer
2015-02-09 10:47 ` [PATCH 07/13] dt: bindings: Add MediaTek MT8135/MT8173 reset controller defines Sascha Hauer
2015-02-09 10:47 ` [PATCH 08/13] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC Sascha Hauer
2015-02-09 10:47 ` [PATCH 09/13] ARM: dts: mediatek: Enable clock support for Mediatek MT8135 Sascha Hauer
2015-02-09 10:51 ` Russell King - ARM Linux
2015-02-09 11:25 ` Sascha Hauer [this message]
2015-02-09 11:27 ` Russell King - ARM Linux
2015-02-09 11:44 ` Sascha Hauer
2015-02-09 10:47 ` [PATCH 10/13] ARM: dts: mt8135: Add pmic wrapper nodes Sascha Hauer
2015-02-09 10:47 ` [PATCH 11/13] ARM: dts: mt8135-evbp1: Add PMIC support Sascha Hauer
2015-02-09 10:47 ` [PATCH 12/13] mfd: dt-bindings: Add bindings for the MediaTek MT6397 PMIC Sascha Hauer
2015-02-09 10:47 ` [PATCH 13/13] mfd: Add support " Sascha Hauer
2015-02-16 9:56 ` Lee Jones
[not found] ` <20150218181904.421.59675@quantum>
[not found] ` <20150219082655.GV12209@pengutronix.de>
[not found] ` <20150219084349.GA12212@x1>
[not found] ` <20150219120409.GW12209@pengutronix.de>
[not found] ` <20150219121304.GH12212@x1>
2015-02-19 21:41 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209112500.GU12209@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Yingjoe.Chen@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=yh.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).