From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933449AbbBIPuQ (ORCPT ); Mon, 9 Feb 2015 10:50:16 -0500 Received: from service87.mimecast.com ([91.220.42.44]:49044 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932713AbbBIPuO convert rfc822-to-8bit (ORCPT ); Mon, 9 Feb 2015 10:50:14 -0500 Date: Mon, 9 Feb 2015 15:50:06 +0000 From: Lorenzo Pieralisi To: Jiang Liu Cc: "Rafael J. Wysocki" , Stephen Rothwell , Bjorn Helgaas , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: linux-next: build failure after merge of the pm tree Message-ID: <20150209155006.GA13772@e102568-lin.cambridge.arm.com> References: <20150209132642.0d61b6ed@canb.auug.org.au> <54D84747.10501@linux.intel.com> <20150209062340.GA10051@e102568-lin.cambridge.arm.com> <2023771.7SV6akbkpr@vostro.rjw.lan> <54D8D075.3030301@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <54D8D075.3030301@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 09 Feb 2015 15:50:11.0658 (UTC) FILETIME=[166E62A0:01D04480] X-MC-Unique: 115020915501202201 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 09, 2015 at 03:21:25PM +0000, Jiang Liu wrote: > On 2015/2/9 23:10, Rafael J. Wysocki wrote: > > On Monday, February 09, 2015 06:23:40 AM Lorenzo Pieralisi wrote: > >> On Mon, Feb 09, 2015 at 05:36:07AM +0000, Jiang Liu wrote: > >>> Hi Rafael and Lorenzo, > >>> With more closer review, I suspect statement "kfree(bus_range)" > >>> in commit d2be00c0fb5a ("of/pci: Free resources on failure in > >>> of_pci_get_host_bridge_resources()") may cause double free of bus_range > >>> because bus_range will also be freed by kfree(window->res); > >> > >> Gah, my bad, you are right, sorry I missed that. Please let me know > >> how you prefer fixing that, you could remove that line as part > >> of the merge commit, or I can send you a patch to apply on top of it, > >> it is a trivial one-line removal. > > > > I re-did the merge. > > > > Please have a look at my linux-next branch again and let me know if that's OK > > with everybody. > I'm OK with new merging commit. Yes, it is ok now, thank you both !! Lorenzo