From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753846AbbBKSLj (ORCPT ); Wed, 11 Feb 2015 13:11:39 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:42958 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753558AbbBKSLh (ORCPT ); Wed, 11 Feb 2015 13:11:37 -0500 Date: Wed, 11 Feb 2015 10:11:28 -0800 From: Dmitry Torokhov To: SF Markus Elfring Cc: linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] Input: Delete an unnecessary check before the function call "input_free_device" Message-ID: <20150211181128.GC29440@dtor-ws> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D39CF4.7030204@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54D39CF4.7030204@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 05, 2015 at 05:40:20PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 5 Feb 2015 17:35:35 +0100 > > The input_free_device() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied, thank you. > --- > drivers/input/joystick/adi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c > index b784257..d09cefa 100644 > --- a/drivers/input/joystick/adi.c > +++ b/drivers/input/joystick/adi.c > @@ -535,8 +535,7 @@ static int adi_connect(struct gameport *gameport, struct gameport_driver *drv) > } > } > fail2: for (i = 0; i < 2; i++) > - if (port->adi[i].dev) > - input_free_device(port->adi[i].dev); > + input_free_device(port->adi[i].dev); > gameport_close(gameport); > fail1: gameport_set_drvdata(gameport, NULL); > kfree(port); > -- > 2.2.2 > -- Dmitry