From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbbBKSYM (ORCPT ); Wed, 11 Feb 2015 13:24:12 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:40892 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752710AbbBKSYL (ORCPT ); Wed, 11 Feb 2015 13:24:11 -0500 Date: Wed, 11 Feb 2015 10:24:03 -0800 From: Dmitry Torokhov To: Hans de Goede Cc: Arnd Bergmann , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chen-Yu Tsai Subject: Re: [PATCH] Input: sun4i-ts: add thermal driver dependency Message-ID: <20150211182403.GE29440@dtor-ws> References: <2265502.1m7jYBaqyh@wuerfel> <54C9E63A.6020806@redhat.com> <20150129185151.GA33547@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150129185151.GA33547@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 29, 2015 at 10:51:51AM -0800, Dmitry Torokhov wrote: > On Thu, Jan 29, 2015 at 08:50:18AM +0100, Hans de Goede wrote: > > Hi, > > > > On 28-01-15 16:17, Arnd Bergmann wrote: > > >The sun4i-ts driver has had a dependency on the thermal code > > >since it was first merged, > > > > The "since it was first merged bit" is not true, this is caused > > by recent changes by ChenYu. > > > > Other then that no objections from me against the proposed fix. > > > > Regards, > > > > Hans > > > > > > but this is not currently enforced > > >in Kconfig, so in some randconfig builds we get > > > > > >drivers/built-in.o: In function `sun4i_ts_remove': > > >:(.text+0x2376f4): undefined reference to `thermal_zone_of_sensor_unregister' > > >drivers/built-in.o: In function `sun4i_ts_probe': > > >:(.text+0x237a94): undefined reference to `thermal_zone_of_sensor_register' > > >:(.text+0x237c00): undefined reference to `thermal_zone_of_sensor_unregister' > > > > > >We need the dependency on THERMAL in order to ensure that this > > >driver becomes a loadable module if the thermal support itself > > >is modular, while the dependency on THERMAL_OF is a runtime dependency > > >and the driver will still build but not work if it is missing. > > > > > >Signed-off-by: Arnd Bergmann > > >Fixes: 6decea7c5438e2 ("Input: add driver for Allwinner sunxi SoC's rtp controller") > > > > > >diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > > >index 58917525126e..e2447f0063b7 100644 > > >--- a/drivers/input/touchscreen/Kconfig > > >+++ b/drivers/input/touchscreen/Kconfig > > >@@ -943,6 +943,8 @@ config TOUCHSCREEN_SUN4I > > > tristate "Allwinner sun4i resistive touchscreen controller support" > > > depends on ARCH_SUNXI || COMPILE_TEST > > > depends on HWMON > > >+ depends on THERMAL > > >+ depends on THERMAL_OF || COMPILE_TEST > > THERMAL_OF does have proper stubs and I do not see why we need to force > having TERMAL even if we don't do compile test. Should the dependency be: > > depends on !THERMAL_OF || TERMAL *ping* Thanks. -- Dmitry