From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbbBKUYo (ORCPT ); Wed, 11 Feb 2015 15:24:44 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:52884 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbbBKUYn (ORCPT ); Wed, 11 Feb 2015 15:24:43 -0500 Date: Wed, 11 Feb 2015 21:24:41 +0100 From: Pavel Machek To: Joe Perches Cc: Richard Weinberger , Dan Carpenter , Andrew Morton , "devel@driverdev.osuosl.org" , gmate.amit@gmail.com, Greg KH , Bas Peters , LKML , Pushpendra Singh , manuel.schoelling@gmx.de, Sudip Mukherjee , Kalle Valo Subject: Re: checkpatch induced patches... Message-ID: <20150211202441.GD29636@amd> References: <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com> <20150210141307.GB15593@sudip-PC> <20150211083328.GJ5206@mwanda> <1423647637.15343.16.camel@perches.com> <20150211105122.GN5206@mwanda> <1423677629.15343.18.camel@perches.com> <20150211183615.GQ5206@mwanda> <1423686025.15343.20.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423686025.15343.20.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2015-02-11 12:20:25, Joe Perches wrote: > On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote: > > On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter wrote: > > > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote: > > >> I'm half tempted to submit some patch like this to > > >> make it difficult to use checkpatch on files outside > > >> of drivers/staging. > > >> > > >> o Only allow checkpatch to be used with the -f/--file > > >> option for drivers/staging/ > > >> o Add an undocumented --force command line option > > > > > > Sure. We could try that. I once sent a patch to make -f generate a > > > warning about not wasting people's time, but this is also ok. > > > > > >> o Make --strict the default for drivers/staging > > > > > > Ack. > > > > FYI: We had already a heated debate on that topic. > > https://lkml.org/lkml/2014/7/17/415 > > Yeah, I remember. > > It's always a pleasure to chat with Borislav. > > This is basically a patch that implements my suggestion > in that thread. > > https://lkml.org/lkml/2014/7/17/427 > > I wonder if the undocumented --force option is acceptable > to Pavel and Kalle. Undocumented options are evil... You can add warning about not wasting people's time in --force documentation... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html