From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754477AbbBKUl6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Feb 2015 15:41:58 -0500
Received: from mail.kernel.org ([198.145.29.136]:37530 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754443AbbBKUl5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Feb 2015 15:41:57 -0500
Date: Wed, 11 Feb 2015 17:42:20 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>, namhyung@kernel.org,
        Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH perf/core 1/2] [BUGFIX] perf-probe: Fix to handle
 optimized not-inlined but has no instance
Message-ID: <20150211204220.GM24251@kernel.org>
References: <20150130093741.30575.41526.stgit@localhost.localdomain>
 <20150130093744.30575.43290.stgit@localhost.localdomain>
 <20150130142135.GA3101@kernel.org>
 <54D72034.2060304@hitachi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54D72034.2060304@hitachi.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sun, Feb 08, 2015 at 05:37:08PM +0900, Masami Hiramatsu escreveu:
> (2015/01/30 23:21), Arnaldo Carvalho de Melo wrote:
> > So perhaps I need a 'noinline' _and_ '__sched', so that I have a "optimized
> > no-inline functions which have only function definition but no actual instance
> > at that point"?
> 
> Ok, actually vmalloc_fault is marked as a nokprobe symbol.
> 
> $ grep vmalloc_fault -r arch/x86/
> arch/x86/mm/fault.c:static noinline int vmalloc_fault(unsigned long address)
> arch/x86/mm/fault.c:NOKPROBE_SYMBOL(vmalloc_fault);
> arch/x86/mm/fault.c:static noinline int vmalloc_fault(unsigned long address)
> arch/x86/mm/fault.c:NOKPROBE_SYMBOL(vmalloc_fault);
> arch/x86/mm/fault.c:                    if (vmalloc_fault(address) >= 0)
> 
> All the symbols which marked by NOKPROBE_SYMBOL macro can not be
> kprobed. And we now have <debugfs>/kprobes/blacklist special file

Ok!

> to get all nokprobe symbols.

> I'll make another perf-probe patch which looks the blacklist before
> trying define new events.

Ok, that will help, improving the error messages is a big priority.

- Arnaldo