From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755365AbbBLJf2 (ORCPT ); Thu, 12 Feb 2015 04:35:28 -0500 Received: from mga14.intel.com ([192.55.52.115]:9608 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754693AbbBLJfZ (ORCPT ); Thu, 12 Feb 2015 04:35:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,564,1418112000"; d="scan'208";a="676835558" Date: Thu, 12 Feb 2015 15:03:05 +0530 From: Vinod Koul To: Lad Prabhakar Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma/edma.c: fix sparse warnings Message-ID: <20150212093304.GL21387@intel.com> References: <1423055007-32102-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423055007-32102-1-git-send-email-prabhakar.csengg@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 04, 2015 at 01:03:27PM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warnings: > > edma.c:537:32: warning: symbol 'edma_prep_dma_memcpy' was not declared. Should it be static? > edma.c:1070:6: warning: symbol 'edma_filter_fn' was not declared. Should it be static? > Applied, thanks. Please ensure you use the right subsystem name and format -- ~Vinod > Signed-off-by: Lad, Prabhakar > --- > Found this issue on linux-next (arm-cortex-a8-gcc version 4.7.3, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/dma/edma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index e95fa7d..276157f 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -15,6 +15,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -534,7 +535,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( > return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags); > } > > -struct dma_async_tx_descriptor *edma_prep_dma_memcpy( > +static struct dma_async_tx_descriptor *edma_prep_dma_memcpy( > struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, > size_t len, unsigned long tx_flags) > { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --