From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbbBML1U (ORCPT ); Fri, 13 Feb 2015 06:27:20 -0500 Received: from mga09.intel.com ([134.134.136.24]:46990 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbbBML1S (ORCPT ); Fri, 13 Feb 2015 06:27:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,570,1418112000"; d="scan'208";a="685258157" Date: Fri, 13 Feb 2015 13:24:57 +0200 From: Heikki Krogerus To: Stephen Boyd Cc: Felipe Balbi , Greg Kroah-Hartman , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] usb: add bus type for USB ULPI Message-ID: <20150213112457.GA27695@kuha.fi.intel.com> References: <1422025978-178336-1-git-send-email-heikki.krogerus@linux.intel.com> <1422025978-178336-2-git-send-email-heikki.krogerus@linux.intel.com> <54DD56F4.5040200@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54DD56F4.5040200@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 12, 2015 at 05:44:20PM -0800, Stephen Boyd wrote: > On 01/23/15 07:12, Heikki Krogerus wrote: > > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > > index e614ef6..753cb08 100644 > > --- a/scripts/mod/file2alias.c > > +++ b/scripts/mod/file2alias.c > > @@ -1176,6 +1176,19 @@ static int do_rio_entry(const char *filename, > > } > > ADD_TO_DEVTABLE("rapidio", rio_device_id, do_rio_entry); > > > > +/* Looks like: mei:S */ > > This comment doesn't look right. Oops. Thanks for catching that one. > > +static int do_ulpi_entry(const char *filename, void *symval, > > + char *alias) > > +{ > > + DEF_FIELD(symval, ulpi_device_id, vendor); > > + DEF_FIELD(symval, ulpi_device_id, product); > > + > > + sprintf(alias, "ulpi:v%04xp%04x", vendor, product); > > + > > + return 1; > > +} > > +ADD_TO_DEVTABLE("ulpi", ulpi_device_id, do_ulpi_entry); -- heikki