From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbbBMWEM (ORCPT ); Fri, 13 Feb 2015 17:04:12 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:34508 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbbBMWEJ (ORCPT ); Fri, 13 Feb 2015 17:04:09 -0500 Date: Fri, 13 Feb 2015 16:03:57 -0600 From: Felipe Balbi To: David Cohen CC: Heikki Krogerus , Felipe Balbi , Greg Kroah-Hartman , Baolu Lu , , , Kishon Vijay Abraham I Subject: Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY Message-ID: <20150213220357.GK26980@saruman.tx.rr.com> Reply-To: References: <1422025978-178336-9-git-send-email-heikki.krogerus@linux.intel.com> <20150124235811.GA24665@psi-dev26.jf.intel.com> <20150126125503.GB28539@kuha.fi.intel.com> <20150126192337.GA13936@psi-dev26.jf.intel.com> <20150127092856.GD28539@kuha.fi.intel.com> <20150127173801.GA8441@psi-dev26.jf.intel.com> <20150128142024.GA2378@kuha.fi.intel.com> <20150128180255.GA7551@psi-dev26.jf.intel.com> <20150129141412.GA2570@kuha.fi.intel.com> <20150213220211.GA25281@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jITzwD3HDGXid3BE" Content-Disposition: inline In-Reply-To: <20150213220211.GA25281@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jITzwD3HDGXid3BE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote: > Hi Felipe, >=20 > [snip] >=20 > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > > index 8d95056..53902ea 100644 > > --- a/drivers/usb/dwc3/dwc3-pci.c > > +++ b/drivers/usb/dwc3/dwc3-pci.c > > @@ -21,6 +21,7 @@ > > #include > > #include > > #include > > +#include > > =20 > > #include "platform_data.h" > > =20 > > @@ -35,6 +36,24 @@ > > =20 > > static int dwc3_pci_quirks(struct pci_dev *pdev) > > { > > + if (pdev->vendor =3D=3D PCI_VENDOR_ID_INTEL && > > + pdev->device =3D=3D PCI_DEVICE_ID_INTEL_BYT) { > > + struct gpio_desc *gpio; > > + > > + gpio =3D gpiod_get_index(&pdev->dev, "reset", 0); > > + if (!IS_ERR(gpio)) { > > + gpiod_direction_output(gpio, 0); > > + gpiod_set_value_cansleep(gpio, 1); > > + gpiod_put(gpio); > > + } > > + gpio =3D gpiod_get_index(&pdev->dev, "cs", 1); > > + if (!IS_ERR(gpio)) { > > + gpiod_direction_output(gpio, 0); > > + gpiod_set_value_cansleep(gpio, 1); > > + gpiod_put(gpio); > > + } > > + } > > + >=20 > A lot has been discussed in other branches of this thread. >=20 > But in resume, this is the last open point to make Heikki's proposal > good on my side. If you accept this ugly quirk (but necessary for > current BYT-CR products when ULPI bus enumerates phy), everything seems > good to me. If you don't accept, we need to figure out a way to get the > platform driver code back to give gpio to phy as platform data in a way > that it could live together with ULPI bus (BYT-CR needs the ULPI bus too). Is this needed to *all* Baytrail devices or could we have devices with updated firmware which won't need this ? I wonder if we should apply the quirk for each known product that actually needs this. Also, I will only accept the series, after I'm shown logs that it works with your known-to-be-broken device. cheers --=20 balbi --jITzwD3HDGXid3BE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU3nTNAAoJEIaOsuA1yqREyCsP/A+is/pdMePUYmZJkkAcZrfn 8MaYsclNHpErUof2OEer39Rb7j+EDHMOG1pqd1Xx0HNmSDV6p7ttJoLRnXK3/+ML JAvWU4FbzL/TyLq9l3jLWSoEyobTTa2FAwJbMzIgO+kh9PDROnyxNjBLcOpMgQFH JvhBmPyjMu1pC/qDT8XXwMUtu2o5ytabHNYFoR1OknaxmpFHiy8LVMiOmQxA+gRI jNEANYeOKkDk3x2sofp7GdN+CG9FeWP4vpKSPT2as794hgp1fU6tgsyAZuybQxFu 5QTEa5/hn2uG0X6qw3/4YN2uDTWBhxGXvaouNEemok0CCuSl/IN4gg7Z59jmH7Sx R5m9lOYJCu9JtgGMRG3DoLmAZKv4kgg6CCOi9qCb4PBLGVxk2IwNktTFjA7eHFea S4wFPCGCJ6vIHnmHl0NurFWzM14EOkK8uBuAl+7CvxXPCXrarOoENlElAe4t0fFv 8ud48rdSiyXhNnvzjohlL6rStk/UmwMZWfD0+AreQ9/7ZEX24jLFBu1mjylFa9sT 5NzUb240Nrgc06QQ0i8goS28RxZaKPKd6f0PTkTogRGMdqJ1b3BB78ZhXUluV4mp MPISxddu7jCmI44rM4h6ffUboeTnjz/QvXqLXv0MfZoRqjkeCHiXw9t7jXBgty4J m4z4jGBbvFuExNXdp6+f =Rvvi -----END PGP SIGNATURE----- --jITzwD3HDGXid3BE--