From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbbBPHzM (ORCPT ); Mon, 16 Feb 2015 02:55:12 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:62762 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbbBPHzK (ORCPT ); Mon, 16 Feb 2015 02:55:10 -0500 Date: Mon, 16 Feb 2015 08:55:06 +0100 From: Ingo Molnar To: Nicholas Krause Cc: bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, --cclinux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c Message-ID: <20150216075506.GA25780@gmail.com> References: <1424030062-8668-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424030062-8668-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nicholas Krause wrote: > This changes the structure sta2x11_dma_ops stucture to > use switolb_dma_supported as it's function for > dma_supported hardware verus setting this value to NULL > as this should be set correctly for when dma_supported > function needs to be called for this hardware. Otherwise > this will cause a bug that will crash a operation needing > to access this function if an intended hardware operation > needs to call it but the kernel has the function pointer > for this structure set to NULL incorrectly. This is a pretty vague description - what specific hardware is affected and how is the bug triggered? Thanks, Ingo