From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755282AbbBPJMZ (ORCPT ); Mon, 16 Feb 2015 04:12:25 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:29998 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbbBPJMX (ORCPT ); Mon, 16 Feb 2015 04:12:23 -0500 Date: Mon, 16 Feb 2015 12:12:23 +0300 From: Dan Carpenter To: Cass May Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable Message-ID: <20150216091222.GX5206@mwanda> References: <1424043618-26947-1-git-send-email-cass@cassm.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424043618-26947-1-git-send-email-cass@cassm.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote: > Clean up Makefile by removing unnecessary definition of DG_NAME. > > Signed-off-by: Cass May > --- > Having done some build tests, it seems that DG_NAME is not needed, > but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, > and moved the latter into the appropriate header. Thanks! Don't resend; this patch is great. But next time just fold both patches together into one patch. It's all part of the same fix really so it falls into the "one thing per patch" rule. regards, dan carpenter