linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pushpendra Singh <pushpendra.singh@smartplayin.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8192e: added parentheses in macros
Date: Mon, 16 Feb 2015 12:54:17 +0300	[thread overview]
Message-ID: <20150216095417.GZ5206@mwanda> (raw)
In-Reply-To: <1424079745-27083-2-git-send-email-pushpendra.singh@smartplayin.com>

On Mon, Feb 16, 2015 at 03:12:25PM +0530, Pushpendra Singh wrote:
> Removed checkpatch.pl error
> ERROR: Macros with complex values should be enclosed in parentheses
> +#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x
> 

You didn't try to compile this code.

regards,
dan carpenter


  reply	other threads:[~2015-02-16  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16  9:42 [PATCH 1/2] staging: rtl8192e: remove unnecessary spaces Pushpendra Singh
2015-02-16  9:42 ` [PATCH 2/2] staging: rtl8192e: added parentheses in macros Pushpendra Singh
2015-02-16  9:54   ` Dan Carpenter [this message]
2015-03-07  0:55 ` [PATCH 1/2] staging: rtl8192e: remove unnecessary spaces Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150216095417.GZ5206@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pushpendra.singh@smartplayin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).