From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932463AbbBPLuG (ORCPT ); Mon, 16 Feb 2015 06:50:06 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:48797 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932388AbbBPLuE (ORCPT ); Mon, 16 Feb 2015 06:50:04 -0500 Date: Mon, 16 Feb 2015 11:49:59 +0000 From: Lee Jones To: Jarkko Nikula Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , lejun.zhu@linux.intel.com, bin.yang@intel.com Subject: Re: [PATCH 3/3] mfd: intel_soc_pmic: Ensure GPIO irq is set to input pin Message-ID: <20150216114959.GD2037@x1> References: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com> <1423832475-5803-3-git-send-email-jarkko.nikula@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1423832475-5803-3-git-send-email-jarkko.nikula@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Feb 2015, Jarkko Nikula wrote: > Surely GPIO irq will be used as an input pin so make sure its direction is > set after requesting. > > Signed-off-by: Jarkko Nikula > --- > Again, I haven't seen any issue. Just a thought if BIOS haven't configured > the pin correctly. > --- > drivers/mfd/intel_soc_pmic_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index 40488e5b52ef..857e5cccdb49 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -31,7 +31,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev) > struct gpio_desc *desc; > int irq; > > - desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0); > + desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0, GPIOD_IN); > if (IS_ERR(desc)) > return PTR_ERR(desc); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog