From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756294AbbBQJq5 (ORCPT ); Tue, 17 Feb 2015 04:46:57 -0500 Received: from foss.arm.com ([217.140.101.70]:52622 "EHLO usa-sjc-mx-foss1.foss.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752058AbbBQJqz (ORCPT ); Tue, 17 Feb 2015 04:46:55 -0500 Date: Tue, 17 Feb 2015 09:46:39 +0000 From: Marc Zyngier To: Yun Wu Cc: "tglx@linutronix.de" , "jason@lakedaemon.net" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/6] irqchip: gicv3-its: use 64KB page as default granule Message-ID: <20150217094639.1114dad5@arm.com> In-Reply-To: <1423992723-5028-3-git-send-email-wuyun.wu@huawei.com> References: <1423992723-5028-1-git-send-email-wuyun.wu@huawei.com> <1423992723-5028-3-git-send-email-wuyun.wu@huawei.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 Feb 2015 09:31:59 +0000 Yun Wu wrote: > The field of page size in register GITS_BASERn might be read-only > if an implementation only supports a single, fixed page size. But > currently the ITS driver will throw out an error when PAGE_SIZE > is less than the minimum size supported by an ITS. So addressing > this problem by using 64KB pages as default granule for all the > ITS base tables. > > Signed-off-by: Yun Wu Acked-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c > b/drivers/irqchip/irq-gic-v3-its.c index 69eeea3..f5bfa42 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -800,7 +800,7 @@ static int its_alloc_tables(struct its_node *its) > { > int err; > int i; > - int psz = PAGE_SIZE; > + int psz = SZ_64K; > u64 shr = GITS_BASER_InnerShareable; > > for (i = 0; i < GITS_BASER_NR_REGS; i++) { > -- > 1.8.0 > > > -- Jazz is not dead. It just smells funny.