From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbbBRNGZ (ORCPT ); Wed, 18 Feb 2015 08:06:25 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:53899 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbbBRNGY (ORCPT ); Wed, 18 Feb 2015 08:06:24 -0500 Date: Wed, 18 Feb 2015 14:06:14 +0100 From: Peter Zijlstra To: Preeti U Murthy Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, rjw@rjwysocki.net, tglx@linutronix.de Subject: Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting Message-ID: <20150218130614.GT5029@twins.programming.kicks-ass.net> References: <20150216121435.203983131@infradead.org> <20150216122413.880378334@infradead.org> <54E2BDA1.3040003@linux.vnet.ibm.com> <20150217103946.GD21418@twins.programming.kicks-ass.net> <54E402BC.2010709@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54E402BC.2010709@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: > > Look at the changelog, Heh, yah, clearly I tl;dr'd that. Indeed. > it explains why tick_takeover must be called > *before* __cpu_die(). Since you reported this, can you test if things work if you move that function call to before __cpu_die() ? I _think_ it should be fine, but what do I know ;-)