From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754483AbbBRSG5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Feb 2015 13:06:57 -0500
Received: from mail-wi0-f170.google.com ([209.85.212.170]:61387 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754423AbbBRSG4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Feb 2015 13:06:56 -0500
Date: Wed, 18 Feb 2015 19:06:51 +0100
From: Ingo Molnar <mingo@kernel.org>
To: nick <xerofoify@gmail.com>
Cc: bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org, --cclinux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] x86:pci: Change  sta2x11_dma_ops stucture to use
 switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c
Message-ID: <20150218180651.GB32019@gmail.com>
References: <1424030062-8668-1-git-send-email-xerofoify@gmail.com>
 <20150216075506.GA25780@gmail.com>
 <54E243F4.4040708@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54E243F4.4040708@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* nick <xerofoify@gmail.com> wrote:

> 
> 
> On 2015-02-16 02:55 AM, Ingo Molnar wrote:
> > 
> > * Nicholas Krause <xerofoify@gmail.com> wrote:
> > 
> >> This changes the structure sta2x11_dma_ops stucture to 
> >> use switolb_dma_supported as it's function for 
> >> dma_supported hardware verus setting this value to NULL 
> >> as this should be set correctly for when dma_supported 
> >> function needs to be called for this hardware. Otherwise 
> >> this will cause a bug that will crash a operation needing 
> >> to access this function if an intended hardware operation 
> >> needs to call it but the kernel has the function pointer 
> >> for this structure set to NULL incorrectly.
> > 
> > This is a pretty vague description - what specific hardware 
> > is affected and how is the bug triggered?
> > 
> > Thanks,
> > 
> > 	Ingo
> > 
> Ingo,
>
> I am unaware of any hardware exactly that this effects. 
> However this should be fixed as a preventive feature in 
> order to avoid future bugs related to hardware that need 
> this function to be supported by the kernel. If you wish 
> I can rewrite the commit message stating this instead of 
> my earlier commit message.

Fair enough, and yes, adding that info would be nice - just 
appending your explanation would do the trick for me!

Thanks,

	Ingo