linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Gross <agross@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Archit Taneja <architt@codeaurora.org>,
	vinod.koul@intel.com, dmaengine@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_bam_dma: Add support for BAM v1.7.0
Date: Fri, 20 Feb 2015 16:28:21 -0600	[thread overview]
Message-ID: <20150220222821.GA13997@qualcomm.com> (raw)
In-Reply-To: <54E72129.30902@mm-sol.com>

On Fri, Feb 20, 2015 at 01:57:29PM +0200, Stanimir Varbanov wrote:

<snip>

> > +	[BAM_IRQ_EN]		= { 0x0001C, 0x00, 0x00, 0x00 },
> > +	[BAM_CNFG_BITS]		= { 0x0007C, 0x00, 0x00, 0x00 },
> > +	[BAM_IRQ_SRCS_EE]	= { 0x03000, 0x00, 0x00, 0x80 },
> > +	[BAM_IRQ_SRCS_MSK_EE]	= { 0x03004, 0x00, 0x00, 0x80 },
> 
> huh, 0x80 should be 0x1000 ?

yeah the SRCS_EE and SRCS_MSK_EE should be 0x1000.  good catch

<snip>

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  reply	other threads:[~2015-02-20 22:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  7:04 [PATCH] dmaengine: qcom_bam_dma: Add support for BAM v1.7.0 Archit Taneja
2015-01-22 21:48 ` Andy Gross
2015-02-10  5:50   ` Stanimir Varbanov
2015-02-20 11:57 ` Stanimir Varbanov
2015-02-20 22:28   ` Andy Gross [this message]
2015-02-23  4:10 ` [PATCH v2] " Archit Taneja
2015-03-06 14:33   ` Ivan T. Ivanov
2015-03-16 16:52   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150220222821.GA13997@qualcomm.com \
    --to=agross@codeaurora.org \
    --cc=architt@codeaurora.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=svarbanov@mm-sol.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).